3D-Druck/Filaman
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 184 Wiki Activity

refactor: streamline task creation in checkVendor and checkFilament functions

Browse Source
This commit is contained in:
Manuel Weiser
2025-08-29 13:09:17 +02:00
parent d12e766cd7
commit 9231a303f3
1 changed files with 18 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/api.cpp
View File

@@ -701,8 +701,6 @@ uint16_t checkVendor(String vendor) {
vTaskDelay(100 / portTICK_PERIOD_MS); vTaskDelay(100 / portTICK_PERIOD_MS);
} }
if(spoolmanApiState == API_IDLE) {
// Erstelle die Task // Erstelle die Task
BaseType_t result = xTaskCreate( BaseType_t result = xTaskCreate(
sendToApi, // Task-Funktion sendToApi, // Task-Funktion
@@ -712,16 +710,6 @@ uint16_t checkVendor(String vendor) {
0, // Priorität 0, // Priorität
NULL // Task-Handle (nicht benötigt) NULL // Task-Handle (nicht benötigt)
); );
} else {
Serial.println("Not spawning new task, API still active!");
delete params;
return 0;
}
// Wait for task completion
while(spoolmanApiState != API_IDLE) {
vTaskDelay(100 / portTICK_PERIOD_MS);
}
// Additional delay to ensure foundVendorId is properly set after API state becomes IDLE // Additional delay to ensure foundVendorId is properly set after API state becomes IDLE
while (foundVendorId == NULL) while (foundVendorId == NULL)
@@ -852,8 +840,6 @@ uint16_t checkFilament(uint16_t vendorId, const JsonDocument& payload) {
params->spoolsUrl = spoolsUrl; params->spoolsUrl = spoolsUrl;
params->updatePayload = ""; // Empty for GET request params->updatePayload = ""; // Empty for GET request
// Check if API is idle before creating task
//if(spoolmanApiState == API_IDLE){
// Erstelle die Task // Erstelle die Task
BaseType_t result = xTaskCreate( BaseType_t result = xTaskCreate(
sendToApi, // Task-Funktion sendToApi, // Task-Funktion
@@ -863,16 +849,6 @@ uint16_t checkFilament(uint16_t vendorId, const JsonDocument& payload) {
0, // Priorität 0, // Priorität
NULL // Task-Handle (nicht benötigt) NULL // Task-Handle (nicht benötigt)
); );
//} else {
// Serial.println("Not spawning new task, API still active!");
// delete params;
// return 0;
//}
// Wait for task completion
while(spoolmanApiState != API_IDLE) {
vTaskDelay(100 / portTICK_PERIOD_MS);
}
// Additional delay to ensure foundFilamentId is properly set after API state becomes IDLE // Additional delay to ensure foundFilamentId is properly set after API state becomes IDLE
while (foundFilamentId == NULL) { while (foundFilamentId == NULL) {